villebro opened a new pull request, #23339: URL: https://github.com/apache/superset/pull/23339
### SUMMARY When querying datasets with "TIMESTAMP WITH TIMEZONE" in Firefox or Safari, Table chart is unable to format the timestamp. This is due to the fact that Trino returns the value in string format that is no tISO-8601 compliant, which causes Firefox and Safari to fail to parse the value. This can be confirmed by trying to create a `Date` object in the browser debugging console: Chrome:  Safari:  Firefox:  Notice how all three browsers are able to parse the value if the space is replaced with a "T" and the timezone is replaced with "Z" (Superset assumes all timestamps to be in UTC format). This PR ensures that "almost ISO-8601" timestamps are always changed into proper ISO format, and any timezone info is converted into UTC. ### AFTER Now the timestamp with timezone displays correctly:  ### BEFORE Previously the timestamp would fail to render:  ### TESTING INSTRUCTIONS 1. Query a dataset on Trino that returns "TIMESTAMP WITH TIMEZONE" without a timegrain 2. Notice how the format fails to render properly. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
