villebro commented on code in PR #23439:
URL: https://github.com/apache/superset/pull/23439#discussion_r1144332775


##########
superset-frontend/src/components/Datasource/DatasourceModal.tsx:
##########
@@ -101,6 +101,10 @@ const DatasourceModal: 
FunctionComponent<DatasourceModalProps> = ({
       postPayload: {
         data: {
           ...currentDatasource,
+          cache_timeout:

Review Comment:
   Currently the Datasource modal is unfortunately using the legacy endpoint, 
which is why this check isn't happening in the API. If it were in fact using 
the V1 API, the old request would produce an error, as it does not satisfy the 
Marshmallow schema.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to