squalou commented on code in PR #23476:
URL: https://github.com/apache/superset/pull/23476#discussion_r1147245318
##########
superset/common/query_context_processor.py:
##########
@@ -447,7 +448,7 @@ def processing_time_offsets( # pylint:
disable=too-many-locals,too-many-stateme
rv_df = pd.concat(rv_dfs, axis=1, copy=False) if time_offsets else df
return CachedTimeOffset(df=rv_df, queries=queries,
cache_keys=cache_keys)
- def get_data(self, df: pd.DataFrame) -> Union[str, List[Dict[str, Any]]]:
+ def get_data(self, df: pd.DataFrame, coltypes:[]) -> Union[str,
List[Dict[str, Any]]]:
Review Comment:
to be honest, I'm still wondering if passing along an array is the best way,
I'm more used to languages where I would have created an object, or a map,
rather than relying on positional informations in arrays.
Maybe a dict would be better.
To be honest any guidance will be welcome.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
