justinpark commented on code in PR #23475:
URL: https://github.com/apache/superset/pull/23475#discussion_r1150884879
##########
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FilterScope/FilterScope.tsx:
##########
@@ -78,10 +80,13 @@ const FilterScope: FC<FilterScopeProps> = ({
const onUpdateFormValues = useCallback(
(formValues: any) => {
+ if (formScopingType === ScopingType.specific) {
+ setLastSpecificScope(formValues.scope);
Review Comment:
I personally prefer to use `useRef` for this case (since it won't need to
re-render)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
