kgabryje commented on PR #23509: URL: https://github.com/apache/superset/pull/23509#issuecomment-1488381068
Looks great, thanks for contribution! 1 nit - when we do `const charts = useSelector(state => state.charts);`, the component will rerender each time any chart changes (for example, when a dashboard with 10 charts loads, the charts change their `chartStatus` `loading -> success -> rendered` - that's 30 changes/rerenders already). It looks like `getVerboseMap` actually only needs chart ids, not full chat objects, so could we do something like `const chartIds = useSelector(state => Object.keys(state.charts));` instead? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
