justinpark opened a new pull request, #23695: URL: https://github.com/apache/superset/pull/23695
### SUMMARY Alternative solution of #23653 When a schema contains a humorous table list, rendering cost of SqlEditorLeftBar is heavy since it requires to iterate millions items. To avoid the lag of using sql editor, we should avoid the LeftBar rendering while typing. This commit fixes the `useSelector` in SqlEditor which triggers the re-rendering of SqlEditorLeftBar anytime redux action triggered. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF After (no lag while typing): https://user-images.githubusercontent.com/1392866/231286835-7c18530d-0fb6-414e-9308-94756c2bede3.mov Before (typing at same speed): https://user-images.githubusercontent.com/1392866/231286786-980a7910-c3bc-483c-8a07-e4399bec58d4.mov ### TESTING INSTRUCTIONS open sqllab with a list of > 100,000 tables typing in the sql editor ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
