yolandazcc commented on code in PR #23836:
URL: https://github.com/apache/superset/pull/23836#discussion_r1178691825
##########
superset/db_engine_specs/clickhouse.py:
##########
@@ -46,14 +47,15 @@
if TYPE_CHECKING:
from superset.models.core import Database
+config = app.config
logger = logging.getLogger(__name__)
class ClickHouseBaseEngineSpec(BaseEngineSpec):
"""Shared engine spec for ClickHouse."""
time_secondary_columns = True
- time_groupby_inline = True
+ time_groupby_inline = config['TIME_GROUPBY_INLINE']
Review Comment:
or delete this override line, just use the base model value False?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
