justinpark opened a new pull request, #23908: URL: https://github.com/apache/superset/pull/23908
### SUMMARY minor regression from #23378 The regex for commented out block also clean up the block within the quotes. Therefore following query threw a syntax error since it removes the quoted value. ``` SELECT * FROM table WHERE column = '--unknown--'; ==> SELECT * FROM table WHERE column = ' ``` This commit adds the condition to skip the quoted block. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF After: ``` SELECT * FROM table WHERE column = '--unknown--'; ==> SELECT * FROM table WHERE column = '--unknown--'; ``` Before: ``` SELECT * FROM table WHERE column = '--unknown--'; ==> SELECT * FROM table WHERE column = ' ``` ### TESTING INSTRUCTIONS Added tests for edge cases ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
