jingapore opened a new issue, #23969: URL: https://github.com/apache/superset/issues/23969
ChartFilter [here](https://github.com/apache/superset/blob/cfc70ea8b0bbb73a5d7189c26867bb64f6f80f67/superset/charts/filters.py#L89) should filter on chart access, **not** datasource access. This has downstream implications: - A newly added dashboard owner who did not create the underlying datasource cannot edit chart. It fails with a 404 error, because chart isn't found. This links to #20381. - This behaviour is unintended. After all, [dashboard ownership comes with chart ownership](https://github.com/apache/superset/blob/cfc70ea8b0bbb73a5d7189c26867bb64f6f80f67/superset/dashboards/commands/update.py#L59). - This is partly a result of how[ `ChartDAO.find_by_id` relies on ChartFilter](https://github.com/apache/superset/blob/cfc70ea8b0bbb73a5d7189c26867bb64f6f80f67/superset/explore/utils.py#L87), which mistakenly checks for datasource ownership. The correct thing is hence for chart access to be separated from datasource access. **ChartFilter needs to be amended.** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
