betodealmeida commented on code in PR #20280:
URL: https://github.com/apache/superset/pull/20280#discussion_r1191381019
##########
superset/config.py:
##########
@@ -333,6 +333,12 @@ def _try_json_readsha(filepath: str, length: int) ->
Optional[str]:
# { 'name': 'Yahoo', 'url': 'https://open.login.yahoo.com/' },
# { 'name': 'Flickr', 'url': 'https://www.flickr.com/<username>' },
+# Settings to enable OAuth2 in the Google Sheets DB engine spec.
+# GSHEETS_OAUTH2_CLIENT_ID = "XXX"
+# GSHEETS_OAUTH2_CLIENT_SECRET = "YYY"
+# GSHEETS_OAUTH2_REDIRECT_URI = "http://localhost:8088/api/v1/database/oauth2/";
Review Comment:
Maybe this should be a dict:
```python
OAUTH2_CREDENTIALS = {
"GSheets": {
"CLIENT_ID": "XXX",
...
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
