betodealmeida commented on code in PR #24060: URL: https://github.com/apache/superset/pull/24060#discussion_r1194373201
########## superset/dashboards/schemas.py: ########## @@ -169,7 +169,7 @@ class RolesSchema(Schema): class TagSchema(Schema): id = fields.Int() name = fields.String() - type = fields.String() + type = fields.Int() Review Comment: What changed here? Does this map to an enum? If so, can we use `fields.Enum` instead? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org