miomiocat commented on PR #23209: URL: https://github.com/apache/superset/pull/23209#issuecomment-1558750734
> Now getting an error from mypy: > > ``` > superset/db_engine_specs/starrocks.py:71: error: Incompatible types in assignment (expression has type Tuple[Tuple[Pattern[str], TINYINT, GenericDataType], Tuple[Pattern[str], Any, GenericDataType], ... <14 more items>], base class "MySQLEngineSpec" defined the type as Tuple[Tuple[Pattern[str], Any, GenericDataType], Tuple[Pattern[str], Any, GenericDataType], Tuple[Pattern[str], Any, GenericDataType], Tuple[Pattern[str], Any, GenericDataType], Tuple[Pattern[str], Any, GenericDataType], Tuple[Pattern[str], Any, GenericDataType], Tuple[Pattern[str], Any, GenericDataType], Tuple[Pattern[str], Any, GenericDataType], Tuple[Pattern[str], Any, GenericDataType], Tuple[Pattern[str], Any, GenericDataType]]) [assignment] > ``` @rusackas Thanks for your reply I've fixed this issue and passed all check except one error in `pre-commit` stage with following message. can you give me some help？ ``` [INFO] This may take a few minutes... isort....................................................................Failed - hook id: isort - files were modified by this hook Fixing /home/runner/work/superset/superset/tests/unit_tests/db_engine_specs/test_starrocks.py Skipped [49](https://github.com/miomiocat/superset/actions/runs/5054598952/jobs/9069709016#step:6:50) files mypy.....................................................................Passed pip-compile-multi verify.................................................Passed check docstring is first.................................................Passed check for added large files..............................................Passed check yaml...............................................................Passed debug statements (python)................................................Passed fix end of files.........................................................Passed trim trailing whitespace.................................................Passed black....................................................................Failed - hook id: black - files were modified by this hook reformatted tests/unit_tests/db_engine_specs/test_starrocks.py All done! ✨ 🍰 ✨ 1 file reformatted, 1271 files left unchanged. prettier.................................................................Passed Blacklist................................................................Passed Helm Docs................................................................Passed Error: Process completed with exit code 1. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
