rusackas commented on PR #21284:
URL: https://github.com/apache/superset/pull/21284#issuecomment-1568735771
@john-bodley someone was just pointing out that this PR broke a sync job. I
think technically since this changes the endpoints/URIs of the API, this would
be considered a breaking change, namely as things move from
```
@expose("/tables/<int:db_id>/<schema>/<substr>/")
@expose("/tables/<int:db_id>/<schema>/<substr>/<force_refresh>/")
@expose("/tables/<int:db_id>/<schema>/<substr>/<force_refresh>/<exact_match>")
```
to
```
@expose("/tables/<int:db_id>/<schema>/")
@expose("/tables/<int:db_id>/<schema>/<force_refresh>/")
@deprecated(new_target="api/v1/database/<int:pk>/tables/")
```
I'm not sure if there's a way to patch this to be non-breaking at this
point, but maybe adding a breaking change notice to `UPDATING.md` would at
least raise awareness.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
