sfirke commented on PR #24262: URL: https://github.com/apache/superset/pull/24262#issuecomment-1572201368
Two things re: docs changes: 1) Typo: "Superset needs **both** `style-src unsafe-inline` CSP directive in order to operate." should be "Superset needs **the** ..." 2) Changing `force_https` to now default to False seems good to me. But it means that this section on the Security page "[Other Talisman security considerations](https://superset.apache.org/docs/security/#other-talisman-security-considerations)" needs to be updated. For instance right now there's text talking about how to override the default value of force_https = True. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
