michael-s-molina commented on code in PR #24176:
URL: https://github.com/apache/superset/pull/24176#discussion_r1217966354
##########
superset/common/query_context_processor.py:
##########
@@ -307,6 +324,40 @@ def _get_timestamp_format(
return df
+ @staticmethod
+ def get_time_grain(
+ query_context: QueryContext, query_object: QueryObject
+ ) -> Any | None:
+ if query_context.form_data:
+ return query_context.form_data.get("time_grain_sqla")
Review Comment:
I can remove this line given that the created function deals with the
different `query_object` variations that depend on `GENERIC_CHART_AXES`. I was
using the `form_data` because it was the only structure that looks consistent
independently of the feature flag.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
