michael-s-molina commented on PR #24176: URL: https://github.com/apache/superset/pull/24176#issuecomment-1583216598
> Draft a [PR](https://github.com/apache/superset/pull/24328/files) to refine the join key generator. please review. Thanks both! @zhaoyongjie That's not the best way to help reviewing a PR. I spent a lot of time debugging the issue, addressing comments and executing tests using Airbnb charts to get to a solution. If you think the solution can be improved, you can make suggestions, provide more context, contribute code to the PR, etc. Completely ignoring the PR and opening your own is not cool 😕 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
