john-bodley commented on code in PR #24323:
URL: https://github.com/apache/superset/pull/24323#discussion_r1224556569
##########
superset/config.py:
##########
@@ -244,7 +244,7 @@ def _try_json_readsha(filepath: str, length: int) -> str |
None:
]
# Whether to run the web server in debug mode or not
-DEBUG = os.environ.get("FLASK_ENV") == "development"
+DEBUG = os.environ.get("FLASK_DEBUG")
Review Comment:
Should there be logic to convert a truthy environment variable to a Python
bool?
```
$ FLASK_DEBUG=true python3
Python 3.9.4 (default, Oct 3 2022, 16:32:43)
[Clang 14.0.0 (clang-1400.0.29.102)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import os
>>> os.environ.get("FLASK_DEBUG")
'true'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
