john-bodley commented on code in PR #24434:
URL: https://github.com/apache/superset/pull/24434#discussion_r1235552918
##########
superset-frontend/src/SqlLab/actions/sqlLab.js:
##########
@@ -1372,12 +1372,11 @@ export function popStoredQuery(urlId) {
export function popSavedQuery(saveQueryId) {
return function (dispatch) {
return SupersetClient.get({
- endpoint: `/api/v1/saved_query/${saveQueryId}`,
+ endpoint: `/savedqueryviewapi/api/get/${saveQueryId}`,
Review Comment:
@jfrag1 thanks for the change. Is there any reason you opted for this
approach as opposed to keeping the new endpoint and relaxing the
`SavedQueryFilter` filter criterion? I guess the merit with the later is it's
clearer how this works as opposed to the somewhat magical (and obscure) FAB
REST API endpoint.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
