rusackas commented on PR #24471: URL: https://github.com/apache/superset/pull/24471#issuecomment-1601493360
Loving this! @villebro and I have been talking about this for a while now, and I'm happy to see that this solution tackles the intricate issue in a clear and straightforward way. The PR description of the fix, the tests, and the code itself all look fantastic to me. If anyone reading this thread has access to Oracle/Snowflake test DBs, or knows their intricacies, please consider adding your name/handle to the [Database Rolodex](https://docs.google.com/spreadsheets/d/1U1qxiLvOX0kBTUGME1AHHi6Ywel6ECF8xk_Qy-V9R8c/edit#gid=0). Unfortunately we have no additional folks to ping for Oracle/Snowflake... yet. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
