justinpark commented on PR #24520: URL: https://github.com/apache/superset/pull/24520#issuecomment-1610232604
> I think we need to investigate why cascadeParentIds has a filter id that is not present in the Redux state anymore. If we find the root cause, this check you added won't be necessary and we'll probably fix other parts of the code that are being affected by this issue. @john-bodley @michael-s-molina The metadata already included the corrupted (non-existence) filter id value which means it happened during migration script. Whether it's corrupted by the migration script or other bug, this means `useFilterDependencies` contains the potential risk by the corrupted data so this nullish check is valuable for UX -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
