kgabryje opened a new pull request, #24542:
URL: https://github.com/apache/superset/pull/24542

   ### SUMMARY
   When user added a native filter with "Select first filter value by default" 
checked and set a scope to a PR that's initially out of scope, the dashboard 
won't load if the native filters bar is in horizontal mode.
   This PR fixes it by setting `forceRender` on the dropdown content in 
horizontal bar if there is a filter with the option selected.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Before:
   
   
https://github.com/apache/superset/assets/15073128/24ac7bdf-561d-47d0-be13-75d8eb89e467
   
   
   After:
   
   
https://github.com/apache/superset/assets/15073128/53d3b6b9-e00d-45f8-a05c-bcd4d50e4244
   
   
   
   ### TESTING INSTRUCTIONS
   1. Create a dashboard and add two tabs to it
   2. Add one chart to each tab, and a third chart under the Tabs element.
   3. Create two dashboard filters with with "Select first filter value by 
default" option checked: one mapped to Tab 1 and the chart outside tabs and the 
other only mapped to Tab 2.
   4. Save filter changes.
   5. Change the filter bar orientation to Horizontal.
   6. Navigate back to Dashboards and access it from the list.
   
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to