john-bodley commented on code in PR #24580:
URL: https://github.com/apache/superset/pull/24580#discussion_r1253412589
##########
superset/databases/filters.py:
##########
@@ -41,6 +41,16 @@ class DatabaseFilter(BaseFilter): # pylint:
disable=too-few-public-methods
# TODO(bogdan): consider caching.
def apply(self, query: Query, value: Any) -> Query:
+ # Dynamic Filters need to be applied to the Query before we filter
Review Comment:
Feels like a good place for a docstring comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
