michael-s-molina commented on code in PR #24559:
URL: https://github.com/apache/superset/pull/24559#discussion_r1253537912
##########
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigModal.tsx:
##########
@@ -580,8 +601,26 @@ function FiltersConfigModal({
<StyledModalWrapper
visible={isOpen}
maskClosable={false}
- title={t('Add and edit filters')}
- width="50%"
+ title={
+ <div
+ css={css`
+ display: flex;
+ justify-content: space-between;
+ align-items: flex-end;
+ margin-right: 50px;
+ `}
+ >
+ <div>{t('Add and edit filters')}</div>
+ <ToggleIcon
+ iconSize="l"
+ iconColor={theme.colors.grayscale.base}
+ onClick={toggleExpand}
+ />
+ </div>
+ }
+ width="70%"
+ {...(expanded && { width: '100%', height: '100%' })}
Review Comment:
Given that `StyleModalWrapper` is already receiving the `expanded` property,
could you deal with `width` and `height` there and remove these two lines?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
