justinpark opened a new pull request, #24599:
URL: https://github.com/apache/superset/pull/24599

   ### SUMMARY
   Since new Dataset creation layout doesn't use virtualized list component for 
the table list, hard to operate the dataset creation with large table set 
(>10k). (mostly browser is frozen while scrolling down)
   
   <img width="953" alt="superset-goalie_-_Airbnb_-_Slack" 
src="https://github.com/apache/superset/assets/1392866/775b0483-d9e3-4c7b-afaf-91b3ada67097";>
   
   Since the left panel layout designed for database/schema/table selection, we 
can reuse the  database/schema/table selector (which uses virtualized list) for 
the same functionality (except the warning icon. However the warning message 
will be shown as is once user selects a table. I think it won't be critical 
without the warning icon on the list)
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   After:
   <img width="873" alt="Screenshot 2023-07-05 at 2 43 20 PM" 
src="https://github.com/apache/superset/assets/1392866/c767afa8-92f4-4e49-b730-c201bdda9e1b";>
   
   Before:
   <img width="874" alt="Screenshot 2023-07-05 at 2 34 43 PM" 
src="https://github.com/apache/superset/assets/1392866/d4716e07-3b63-423f-8a49-ab42a8371d67";>
   
   ### TESTING INSTRUCTIONS
   Go to datasets and create new dataset
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [x] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to