michael-s-molina commented on code in PR #24599:
URL: https://github.com/apache/superset/pull/24599#discussion_r1256396653
##########
superset-frontend/src/components/WarningIconWithTooltip/index.tsx:
##########
@@ -39,7 +39,7 @@ function WarningIconWithTooltip({
<Icons.AlertSolid
iconColor={theme.colors.alert.base}
iconSize={size}
- css={{ marginRight: theme.gridUnit * 2 }}
+ css={{ marginRight: theme.gridUnit * 0.5 }}
Review Comment:
This change shouldn't be made in the component as it will affect many parts
of the application. Could you make this adjustment in `TableSelector`?
##########
superset-frontend/src/components/WarningIconWithTooltip/index.tsx:
##########
@@ -39,7 +39,7 @@ function WarningIconWithTooltip({
<Icons.AlertSolid
iconColor={theme.colors.alert.base}
iconSize={size}
- css={{ marginRight: theme.gridUnit * 2 }}
+ css={{ marginRight: theme.gridUnit * 0.5 }}
Review Comment:
This change shouldn't be made in the component as it will affect many parts
of the application. Could you make this adjustment in `TableOption`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
