john-bodley opened a new pull request, #24626:
URL: https://github.com/apache/superset/pull/24626

   <!---
   Please write the PR title following the conventions at 
https://www.conventionalcommits.org/en/v1.0.0/
   Example:
   fix(dashboard): load charts correctly
   -->
   
   ### SUMMARY
   
   This is a partial revert of https://github.com/apache/superset/pull/12666 
which was likely authored when Apache's CI was under heavy load. Specifically 
it reenables a subset of the "core" backend and frontend workflows when a PR is 
in draft mode. This enables the author to iterate on fixing any issues prior to 
it being deemed eligible for review. 
   
   For reference here's the workflows which still have this disabled, 
   
   ```
   $ git grep draft
   docker-release.yml:    if: github.event.pull_request.draft == false
   docker.yml:    if: github.event.pull_request.draft == false
   embedded-sdk-test.yml:    if: github.event.pull_request.draft == false
   superset-e2e.yml:    if: github.event.pull_request.draft == false
   superset-python-misc.yml:    if: github.event.pull_request.draft == false
   superset-python-presto-hive.yml:    if: github.event.pull_request.draft == 
false
   superset-python-presto-hive.yml:    if: github.event.pull_request.draft == 
false
   superset-translations.yml:    if: github.event.pull_request.draft == false
   superset-translations.yml:    if: github.event.pull_request.draft == false
   superset-websocket.yml:    if: github.event.pull_request.draft == false
   ```
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TESTING INSTRUCTIONS
   
   CI.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to