john-bodley commented on code in PR #24625:
URL: https://github.com/apache/superset/pull/24625#discussion_r1258593353
##########
superset/datasets/commands/create.py:
##########
@@ -47,9 +46,7 @@ def run(self) -> Model:
# Creates SqlaTable (Dataset)
dataset = DatasetDAO.create(self._properties, commit=False)
- # Updates columns and metrics from the dataset
- dataset.metrics = [SqlMetric(metric_name="COUNT(*)",
expression="COUNT(*)")]
Review Comment:
@hughhhh would you mind linking to where this `COUNT(*)` metric is being
created?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
