john-bodley commented on code in PR #24675:
URL: https://github.com/apache/superset/pull/24675#discussion_r1261807047
##########
tests/integration_tests/core_tests.py:
##########
@@ -391,7 +393,7 @@ def test_databaseview_edit(self, username="admin"):
)
def test_warm_up_cache(self):
self.login()
- slc = self.get_slice("Girls", db.session)
+ slc = self.get_slice("Top 10 Girl Name Share", db.session)
Review Comment:
See previous comment.
##########
tests/integration_tests/core_tests.py:
##########
@@ -418,10 +420,10 @@ def test_cache_logging(self):
self.login("admin")
store_cache_keys = app.config["STORE_CACHE_KEYS_IN_METADATA_DB"]
app.config["STORE_CACHE_KEYS_IN_METADATA_DB"] = True
- girls_slice = self.get_slice("Girls", db.session)
-
self.get_json_resp(f"/superset/warm_up_cache?slice_id={girls_slice.id}")
+ slc = self.get_slice("Top 10 Girl Name Share", db.session)
Review Comment:
See previous comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
