Always-prog commented on PR #24710:
URL: https://github.com/apache/superset/pull/24710#issuecomment-1638115305
> > Pieces of form_data can occur when users switch from pvt2 tables to
legacy pivot.
>
> Thanks for the fix @Always-prog! If this behavior happens for Pivot Table,
it may also happen for other chart types. Would you mind resolving this in a
more global way? You can skip rename keys in `base.py`:
>
> ```
> def _migrate(self) -> None:
> ...
> rv_data = {}
> for key, value in self.data.items():
> // ADD SOMETHING HERE TO SKIP NEW VERSION KEYS
>
> if key in self.rename_keys and self.rename_keys[key] in rv_data:
> raise ValueError("Duplicate key in target viz")
> ```
Then, can we just instead of an error "Duplicate key in target viz" just
skip that keys?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
