john-bodley commented on code in PR #24709:
URL: https://github.com/apache/superset/pull/24709#discussion_r1267062291
##########
superset/daos/dashboard.py:
##########
@@ -63,8 +63,6 @@ def get_by_id_or_slug(cls, id_or_slug: int | str) ->
Dashboard:
query = (
db.session.query(Dashboard)
.filter(id_or_slug_filter(id_or_slug))
- .outerjoin(Slice, Dashboard.slices)
Review Comment:
@dpgaspar would you mind looking into this as it seems you added this logic
in https://github.com/apache/superset/pull/22358? Note it's interesting that
the unit/integration tests passed with the removal of these two lines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
