mistercrunch commented on code in PR #24747:
URL: https://github.com/apache/superset/pull/24747#discussion_r1269961036
##########
superset-frontend/webpack.config.js:
##########
@@ -419,11 +419,6 @@ const config = {
{
loader: '@svgr/webpack',
options: {
- icon: true,
Review Comment:
are the defaults good? do we want to be explicit as in
```javascript
options: {
// making sure that svgo isn't setting width:1em
icon: false,
// don't allow svgo to alter/opitmize the svg
svgo: false,
},
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
