john-bodley opened a new pull request, #24773: URL: https://github.com/apache/superset/pull/24773
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY The `superset.connectors` submodule represents a bygone error of Superset when we supported both the Druid NoSQL and SQLAlchemy database engine connectors. Many of the base models and views are superfluous as they're only extended by one and only class. This PR: 1. Integrates the `BaseColumn` and `BaseMetric` classes into the `TableColumn` and `SqlMetric` classes respectively. 2. Integrates the `DatasourceModelView` class into the `TableModelView` class. 3. Moves `superset.connectors.base.models.BaseDatasource` to `superset.connectors.base.models.BaseDatasource`. Ideally I would love to deprecate the `BaseDatasource` however at this stage I'm not brave enough. Currently (in addition to `SqlaTable` class) the ` the `AnnotationDatasource` class is derived from it and thus sunsetting it is somewhat problematic. We maybe need to remove the `AnnotationDatasource` class somewhat like the `Query` class which behaves somewhat like a datasource/dataset. Without doubt the `superset.connectors` submodule should be abandoned with the models, views, and utilities moved elsewhere, but I thought it would be prudent to take smaller bites. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS CI. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
