john-bodley commented on code in PR #24774:
URL: https://github.com/apache/superset/pull/24774#discussion_r1273836534
##########
superset/views/base.py:
##########
@@ -120,6 +120,7 @@
"ALERT_REPORTS_DEFAULT_RETENTION",
"ALERT_REPORTS_DEFAULT_WORKING_TIMEOUT",
"NATIVE_FILTER_DEFAULT_ROW_LIMIT",
+ "TALISMAN_ENABLED",
Review Comment:
Why do we need to expose this configuration variable to the frontend as
there's no reference to this in the frontend?
##########
docker/pythonpath_dev/superset_config.py:
##########
@@ -66,6 +66,8 @@ def get_env_variable(var_name: str, default: Optional[str] =
None) -> str:
REDIS_CELERY_DB = get_env_variable("REDIS_CELERY_DB", "0")
REDIS_RESULTS_DB = get_env_variable("REDIS_RESULTS_DB", "1")
+TALISMAN_ENABLED = get_env_variable("TALISMAN_ENABLED", "False")
Review Comment:
I think this should be defined in `superset/config.py` as well so in
`superset/views/base.py` you would do `conf["TASLISMAN_ENABLED"]` rather than
`conf.get("TALISMAN_ENABLED", ...)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
