justinpark commented on code in PR #24847:
URL: https://github.com/apache/superset/pull/24847#discussion_r1281147704
##########
superset-frontend/src/SqlLab/components/AceEditorWrapper/useKeywords.ts:
##########
@@ -50,6 +50,11 @@ const EMPTY_LIST = [] as typeof sqlKeywords;
const { useQueryState: useSchemasQueryState } = schemaEndpoints.schemas;
const { useQueryState: useTablesQueryState } = tableEndpoints.tables;
+const getHelperText = (value: string) =>
+ value.length > 30 && {
Review Comment:
@michael-s-molina
Unfortunately it's very complicated to make the tooltip dynamically.
First, ace-editor doesn't provide the enough apis to handle the tooltip
dynamically. (it's virtualized list so it should calculate the each item width
dynamically as typed.)
To make the solution simple, it uses the static length since the tooltip
width is fixed size (260px) and we can mostly guarantee the 30 characters are
approaching the max. width(260px).
In my personal opinion, we can add `docText` for all cases to be
consistence/simple for UX.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
