sebastianliebscher opened a new pull request, #24896:
URL: https://github.com/apache/superset/pull/24896

   ### SUMMARY
   This PR uses 
[contextlib](https://docs.python.org/3/library/contextlib.html)'s `suppress` 
for passing a specific error, instead of `pass`ing in an exception handler. The 
context manager shortens the code a bit and explicitly states the authors 
intend to ignore specific errors, thus improving readability.
   
   ### TESTING INSTRUCTIONS
   run unit and integration tests
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to