jfrag1 commented on code in PR #24894:
URL: https://github.com/apache/superset/pull/24894#discussion_r1286167282
##########
tests/integration_tests/datasets/api_tests.py:
##########
@@ -1711,12 +1712,15 @@ def test_bulk_delete_dataset_items(self):
assert rv.status_code == 200
expected_response = {"message": f"Deleted {len(datasets)} datasets"}
assert data == expected_response
+ deleted_datasets = datasets
datasets = (
db.session.query(SqlaTable)
.filter(SqlaTable.table_name.in_(self.fixture_tables_names))
.all()
)
assert datasets == []
+ for dataset in deleted_datasets:
+ setattr(dataset, "_deleted", True)
Review Comment:
Updated with a better method of checking whether the object was deleted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
