betodealmeida commented on code in PR #24909:
URL: https://github.com/apache/superset/pull/24909#discussion_r1286445224
##########
tests/integration_tests/databases/api_tests.py:
##########
@@ -2850,6 +2850,136 @@ def test_function_names(self, mock_get_function_names):
assert rv.status_code == 200
assert response == {"function_names": ["AVG", "MAX", "SUM"]}
+ def test_function_names_sqlite(self):
+ example_db = get_example_database()
+ if example_db.backend != "sqlite":
+ return
+
+ self.login(username="admin")
+ uri = "api/v1/database/1/function_names/"
+
+ rv = self.client.get(uri)
+ response = json.loads(rv.data.decode("utf-8"))
+
+ assert rv.status_code == 200
+ assert response == {
+ "function_names": [
+ "abs",
Review Comment:
Yeah, I tend to avoid comparing results to imported variables in unit tests,
since it can lead to mistakes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
