dpgaspar commented on code in PR #25003:
URL: https://github.com/apache/superset/pull/25003#discussion_r1297020370
##########
superset/utils/database.py:
##########
@@ -65,11 +65,7 @@ def get_or_create_db(
def get_example_database() -> Database:
- db_uri = (
- current_app.config.get("SQLALCHEMY_EXAMPLES_URI")
- or current_app.config["SQLALCHEMY_DATABASE_URI"]
- )
- return get_or_create_db("examples", db_uri)
+ return get_or_create_db("examples",
current_app.config["SQLALCHEMY_EXAMPLES_URI"])
Review Comment:
left a comment on #23399, no strong opinions about allowing DML/upload on
the examples db, yet I do see this as a readonly db
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
