hughhhh commented on code in PR #24839:
URL: https://github.com/apache/superset/pull/24839#discussion_r1300670543
##########
superset/tags/api.py:
##########
@@ -131,6 +141,131 @@ def __repr__(self) -> str:
f'{self.appbuilder.app.config["VERSION_SHA"]}'
)
+ @expose("/", methods=("POST",))
+ @protect()
+ @safe
+ @statsd_metrics
+ @event_logger.log_this_with_context(
+ action=lambda self, *args, **kwargs: f"{self.__class__.__name__}.post",
+ log_to_statsd=False,
+ )
+ def post(self) -> Response:
+ """Creates a new Tags and tag items
+ ---
+ post:
+ description: >-
+ Create a new Tag
+ requestBody:
+ description: Tag schema
+ required: true
+ content:
+ application/json:
+ schema:
+ $ref: '#/components/schemas/{{self.__class__.__name__}}.post'
+ responses:
+ 201:
+ description: Tag added
+ content:
+ application/json:
+ schema:
+ type: object
+ properties:
+ id:
+ type: number
+ result:
+ $ref:
'#/components/schemas/{{self.__class__.__name__}}.post'
+ 400:
+ $ref: '#/components/responses/400'
+ 401:
+ $ref: '#/components/responses/401'
+ 422:
+ $ref: '#/components/responses/422'
+ 500:
+ $ref: '#/components/responses/500'
+ """
+ try:
+ item = self.add_model_schema.load(request.json)
+ except ValidationError as error:
+ return self.response_400(message=error.messages)
+ try:
+ CreateCustomTagWithRelationshipsCommand(item).run()
+ return self.response(201)
+ except TagInvalidError as ex:
+ return self.response_422(message=ex.normalized_messages())
+ except TaggedObjectDeleteFailedError as ex:
Review Comment:
yea wrong error, but 422 seems fitting:
```
422 Unprocessable Entity: This can be used if the request was well-formed
but semantically incorrect, such as if it violates business logic rules.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
