justinpark opened a new pull request, #25151: URL: https://github.com/apache/superset/pull/25151
### SUMMARY Part 4-8 of SQLLab SPA migration work: [detail link](https://docs.google.com/document/d/1opyNuaw-CEAD9tG6fx_zqNcZwe3_soQgsnSJTP4mQkk/edit?usp=sharing) - Change the url from /superset/sqllab to /sqllab - Update frontend routes - Update unit tests and cypress e2e tests - Update redirectSQLLab logic For the redirect logic, it will replace the SupersetClient.post redirection by react-router redirection with the location state for the post payload data. This means the redundant form_data serialize/deserialize logic has been discarded (which is also another performance gain). FYI: This commit does *not* include the delete work (i.e. old entrypoint related files, redirect legacy endpoint to new endpoint). This work will be a separate PR to minimize the regression rollback. ### TESTING INSTRUCTIONS Make sure the SQL Lab page works as before but in the context of SPA (does not reload the page when navigating) ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
