villebro commented on PR #25150: URL: https://github.com/apache/superset/pull/25150#issuecomment-1701732662
@KSPT-taylorjohn there's a lint issue: ```patch diff --git a/superset/models/helpers.py b/superset/models/helpers.py index 810de46372..6ae1e4d0a0 100644 --- a/superset/models/helpers.py +++ b/superset/models/helpers.py @@ -102,7 +102,6 @@ SERIES_LIMIT_SUBQ_ALIAS = "series_limit" ADVANCED_DATA_TYPES = config["ADVANCED_DATA_TYPES"] - def validate_adhoc_subquery( sql: str, database_id: int, @@ -1470,7 +1469,7 @@ class ExploreMixin: # pylint: disable=too-many-public-methods db_engine_spec.make_label_compatible(column) for column in utils.get_column_names( columns=series_columns or [], - ) + ) ] # deprecated, to be removed in 2.0 if is_timeseries and timeseries_limit: ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org