[GitHub] [superset] justinpark commented on pull request #25133: fix(sqllab): Invalid start date

[via GitHub]

justinpark commented on PR #25133:
URL: https://github.com/apache/superset/pull/25133#issuecomment-1703073701

   
   > justinpark thanks for adding the date. We are using the above format in 
the Query History Tab. Do we wanna keep it the same here for the sake of 
consistency? I am fine with either though :)
   
   Sounds good. I changed to same format as Query History as well as from 
`MM/DD/YYYY` to `L` (which is like 09/04/1986 in local format, so date value 
comes first in eu countries)
   
   ![Screenshot 2023-09-01 at 10 04 27 
AM](https://github.com/apache/superset/assets/1392866/1768b4fd-1b67-4da8-8143-1b45d67e1643)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org