giftig commented on code in PR #25340:
URL: https://github.com/apache/superset/pull/25340#discussion_r1335573284
##########
superset/security/manager.py:
##########
@@ -784,11 +786,17 @@ def sync_role_definitions(self) -> None:
self.create_custom_permissions()
+ #Fetch all pvms
+ pvms = self.get_session.query(PermissionView).options(
+ eagerload(PermissionView.permission),
+ eagerload(PermissionView.view_menu)).all()
+ pvms = [p for p in pvms if p.permission and p.view_menu]
Review Comment:
Ah yeah, I see you haven't changed this. Fair enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
