rusackas commented on PR #17906: URL: https://github.com/apache/superset/pull/17906#issuecomment-1749740928
OK, I got it working, but realized a few things along the way: 1) Storybook isn't running (not the fault of this PR, but just sayin'...) 2) This doesn't seem to really support a temporal X Axis via the "Dimension" input, which sure would be nice. 3) If the first values in a series are negative, they're still above the 0 line, and lead to a non-waterfall chart like so <img width="1664" alt="Screenshot 2023-10-05 at 3 16 21 PM" src="https://github.com/apache/superset/assets/812905/4796ab3e-e971-48f5-836a-606a9dd79c3d";> That said, I was still able to get a reasonable working example. <img width="1649" alt="Screenshot 2023-10-05 at 4 01 21 PM" src="https://github.com/apache/superset/assets/812905/32375f18-b87f-430a-a6bd-90a9fafdf197";> I say we merge this thing and then debug it on new PRs. I'll give the code a quick review... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
