eschutho commented on code in PR #25112:
URL: https://github.com/apache/superset/pull/25112#discussion_r1358487880
##########
superset-frontend/src/explore/components/SaveModal.test.jsx:
##########
@@ -226,3 +233,28 @@ test('set dataset name when chart source is query', () => {
expect(wrapper.find('[data-test="new-dataset-name"]')).toExist();
expect(wrapper.state().datasetName).toBe('test');
});
+
+test('make sure slice_id in the URLSearchParams before the redirect', () => {
+ const myProps = {
+ ...defaultProps,
+ slice: { slice_id: 1, slice_name: 'title', owners: [1] },
+ actions: {
+ setFormData: jest.fn(),
+ updateSlice: jest.fn(() => Promise.resolve({ id: 1 })),
+ getSliceDashboards: jest.fn(),
+ },
+ user: { userId: 1 },
+ history: {
+ replace: jest.fn(),
+ },
+ dispatch: jest.fn(),
+ };
+
+ const saveModal = new PureSaveModal(myProps);
+ saveModal.setState = jest.fn();
Review Comment:
do you need this still?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
