john-bodley commented on code in PR #25344:
URL: https://github.com/apache/superset/pull/25344#discussion_r1379176886
##########
superset-frontend/src/SqlLab/actions/sqlLab.js:
##########
@@ -1033,6 +1033,19 @@ export function queryEditorSetSql(queryEditor, sql) {
return { type: QUERY_EDITOR_SET_SQL, queryEditor, sql };
}
+export function formatQuery(queryEditor) {
+ return function (dispatch, getState) {
+ const { sql } = getUpToDateQuery(getState(), queryEditor);
+ return SupersetClient.post({
Review Comment:
There seems to be a number of pros with having this on the backend
including: custom formatting, dialect specific formatting, and consistency
throughout the application.
@villebro has experience working with frontend SQL formatting and ran into a
number of issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
