john-bodley commented on code in PR #25855:
URL: https://github.com/apache/superset/pull/25855#discussion_r1381906335
##########
superset-frontend/src/SqlLab/components/QueryLimitSelect/QueryLimitSelect.test.tsx:
##########
@@ -106,13 +105,25 @@ describe('QueryLimitSelect', () => {
});
it('renders dropdown select', async () => {
- const { baseElement, getByRole } = setup({}, mockStore(initialState));
+ const { baseElement, getAllByRole, getByRole } = setup(
+ { maxRow: 50000 },
+ mockStore(initialState),
+ );
const dropdown = baseElement.getElementsByClassName(
'ant-dropdown-trigger',
)[0];
userEvent.click(dropdown);
await waitFor(() => expect(getByRole('menu')).toBeInTheDocument());
+
+ const expectedLabels = [10, 100, 1000, 10000, 50000].map(i =>
Review Comment:
@giftig would you also mind adding a couple of tests: i) when `maxRow` is a
factor of 10, and ii) when the `maxRow` is less than 10?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
