john-bodley commented on code in PR #25903: URL: https://github.com/apache/superset/pull/25903#discussion_r1385909645
########## superset-frontend/packages/superset-ui-core/src/utils/html.tsx: ########## @@ -28,7 +28,7 @@ export function sanitizeHtml(htmlString: string) { } export function isProbablyHTML(text: string) { - return /<[^>]+>/.test(text); + return /<\/?[a-z][\s\S]*>/i.test(text); Review Comment: @justinpark is there merit in using a non-regex implementation, i.e., something like [this](https://stackoverflow.com/a/55680987)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org