jansule commented on code in PR #25869:
URL: https://github.com/apache/superset/pull/25869#discussion_r1389083065
##########
superset-frontend/package.json:
##########
@@ -138,12 +139,18 @@
"d3-scale": "^2.1.2",
"dom-to-image-more": "^2.10.1",
"dom-to-pdf": "^0.3.2",
+ "echarts": "^5.4.1",
"emotion-rgba": "0.0.9",
"fast-glob": "^3.2.7",
"fontsource-fira-code": "^4.0.0",
"fs-extra": "^10.0.0",
"fuse.js": "^6.4.6",
"geolib": "^2.0.24",
+ "geostyler": "^12.0.2",
+ "geostyler-data": "^1.0.0",
+ "geostyler-openlayers-parser": "^4.2.1",
+ "geostyler-style": "^7.4.0",
+ "geostyler-wfs-parser": "^2.0.0",
Review Comment:
I added these to the root directory as they are needed by the
`<LayerConfigsControl />` which was added to `superset-frontend/src/explore`
and not to the plugin itself.
The only reason the control is not included in the plugin directory is, that
the `<ControlFormItem />` was moved from `@superset-ui/core` to
`superset-frontend/src/explore`, so I cannot import it in the plugin directory.
This component, however, is needed for a consistent UI of the controls.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
