giftig commented on PR #25950: URL: https://github.com/apache/superset/pull/25950#issuecomment-1805952519
There's a slight wrinkle here in that the datetime format actually varies depending on the engine, which the integration tests have highlighted. Unfortunately to preserve the information to the underlying dataset we need to parse it back into a `datetime` regardless, since we only have a stringified version in the context here, and when going direct, we have a `datetime` instead. That means I've had to be a little bit flexible in how the datetime is parsed, so I've handled the most major formats and done it in a safe way, falling back to omitting it if not present. Not sure if we can somehow preserve this information better; I think this is the best we can do without considering some major changes to the way this is working. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
